lkml.org 
[lkml]   [2019]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 4/5] staging: iio: adc: Adding temp var to improve readability
    Creating a temporary variable to improve readability

    Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
    ---
    drivers/staging/iio/adc/ad7280a.c | 55 ++++++++++++++++++---------------------
    1 file changed, 25 insertions(+), 30 deletions(-)

    diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
    index d81a5bd..5d848aa 100644
    --- a/drivers/staging/iio/adc/ad7280a.c
    +++ b/drivers/staging/iio/adc/ad7280a.c
    @@ -784,43 +784,38 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
    for (i = 0; i < st->scan_cnt; i++) {
    if (((channels[i] >> 23) & 0xF) <= AD7280A_CELL_VOLTAGE_6) {
    if (((channels[i] >> 11) & 0xFFF) >=
    - st->cell_threshhigh)
    - iio_push_event(indio_dev,
    - IIO_EVENT_CODE(IIO_VOLTAGE,
    - 1,
    - 0,
    - IIO_EV_DIR_RISING,
    - IIO_EV_TYPE_THRESH,
    - 0, 0, 0),
    + st->cell_threshhigh) {
    + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
    + IIO_EV_DIR_RISING,
    + IIO_EV_TYPE_THRESH,
    + 0, 0, 0);
    + iio_push_event(indio_dev, tmp,
    iio_get_time_ns(indio_dev));
    - else if (((channels[i] >> 11) & 0xFFF) <=
    - st->cell_threshlow)
    - iio_push_event(indio_dev,
    - IIO_EVENT_CODE(IIO_VOLTAGE,
    - 1,
    - 0,
    - IIO_EV_DIR_FALLING,
    - IIO_EV_TYPE_THRESH,
    - 0, 0, 0),
    + } else if (((channels[i] >> 11) & 0xFFF) <=
    + st->cell_threshlow) {
    + u64 tmp = IIO_EVENT_CODE(IIO_VOLTAGE, 1, 0,
    + IIO_EV_DIR_FALLING,
    + IIO_EV_TYPE_THRESH,
    + 0, 0, 0);
    + iio_push_event(indio_dev, tmp,
    iio_get_time_ns(indio_dev));
    + }
    } else {
    - if (((channels[i] >> 11) & 0xFFF) >= st->aux_threshhigh)
    - iio_push_event(indio_dev,
    - IIO_UNMOD_EVENT_CODE(
    - IIO_TEMP,
    - 0,
    + if (((channels[i] >> 11) & 0xFFF) >=
    + st->aux_threshhigh) {
    + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
    IIO_EV_TYPE_THRESH,
    - IIO_EV_DIR_RISING),
    + IIO_EV_DIR_RISING);
    + iio_push_event(indio_dev, tmp,
    iio_get_time_ns(indio_dev));
    - else if (((channels[i] >> 11) & 0xFFF) <=
    - st->aux_threshlow)
    - iio_push_event(indio_dev,
    - IIO_UNMOD_EVENT_CODE(
    - IIO_TEMP,
    - 0,
    + } else if (((channels[i] >> 11) & 0xFFF) <=
    + st->aux_threshlow) {
    + u64 tmp = IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
    IIO_EV_TYPE_THRESH,
    - IIO_EV_DIR_FALLING),
    + IIO_EV_DIR_FALLING);
    + iio_push_event(indio_dev, tmp,
    iio_get_time_ns(indio_dev));
    + }
    }
    }

    --
    2.7.4
    \
     
     \ /
      Last update: 2019-03-23 13:54    [W:4.386 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site