Messages in this thread | | | Date | Sat, 23 Mar 2019 09:34:13 +0100 | From | Stefan Agner <> | Subject | Re: [PATCH] regulator: rn5t618: Constify regulator_desc |
| |
On 20.03.2019 13:10, Axel Lin wrote: > The regulator_desc never need to be modified, so define them as const as a > hint to the compiler that they can go into .rodata. > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
Looks good to me.
Reviewed-by: Stefan Agner <stefan@agner.ch>
-- Stefan
> --- > drivers/regulator/rn5t618-regulator.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/regulator/rn5t618-regulator.c > b/drivers/regulator/rn5t618-regulator.c > index 790a4a73ea2c..a79c0c43b9f8 100644 > --- a/drivers/regulator/rn5t618-regulator.c > +++ b/drivers/regulator/rn5t618-regulator.c > @@ -46,7 +46,7 @@ static const struct regulator_ops rn5t618_reg_ops = { > .vsel_mask = (vmask), \ > } > > -static struct regulator_desc rn5t567_regulators[] = { > +static const struct regulator_desc rn5t567_regulators[] = { > /* DCDC */ > REG(DCDC1, DC1CTL, BIT(0), DC1DAC, 0xff, 600000, 3500000, 12500), > REG(DCDC2, DC2CTL, BIT(0), DC2DAC, 0xff, 600000, 3500000, 12500), > @@ -63,7 +63,7 @@ static struct regulator_desc rn5t567_regulators[] = { > REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), > }; > > -static struct regulator_desc rn5t618_regulators[] = { > +static const struct regulator_desc rn5t618_regulators[] = { > /* DCDC */ > REG(DCDC1, DC1CTL, BIT(0), DC1DAC, 0xff, 600000, 3500000, 12500), > REG(DCDC2, DC2CTL, BIT(0), DC2DAC, 0xff, 600000, 3500000, 12500), > @@ -79,7 +79,7 @@ static struct regulator_desc rn5t618_regulators[] = { > REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), > }; > > -static struct regulator_desc rc5t619_regulators[] = { > +static const struct regulator_desc rc5t619_regulators[] = { > /* DCDC */ > REG(DCDC1, DC1CTL, BIT(0), DC1DAC, 0xff, 600000, 3500000, 12500), > REG(DCDC2, DC2CTL, BIT(0), DC2DAC, 0xff, 600000, 3500000, 12500), > @@ -107,7 +107,7 @@ static int rn5t618_regulator_probe(struct > platform_device *pdev) > struct rn5t618 *rn5t618 = dev_get_drvdata(pdev->dev.parent); > struct regulator_config config = { }; > struct regulator_dev *rdev; > - struct regulator_desc *regulators; > + const struct regulator_desc *regulators; > int i; > int num_regulators = 0;
| |