lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 095/280] ixgbe: fix older devices that do not support IXGBE_MRQC_L3L4TXSWEN
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 156a67a9065e3339be85f811d1b13b920e50d73b ]

    The enabling L3/L4 filtering for transmit switched packets for all
    devices caused unforeseen issue on older devices when trying to send UDP
    traffic in an ordered sequence. This bit was originally intended for X550
    devices, which supported this feature, so limit the scope of this bit to
    only X550 devices.

    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    index 6cdd58d9d461..410d5d3aa393 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    @@ -3924,8 +3924,11 @@ static void ixgbe_setup_mrqc(struct ixgbe_adapter *adapter)
    else
    mrqc = IXGBE_MRQC_VMDQRSS64EN;

    - /* Enable L3/L4 for Tx Switched packets */
    - mrqc |= IXGBE_MRQC_L3L4TXSWEN;
    + /* Enable L3/L4 for Tx Switched packets only for X550,
    + * older devices do not support this feature
    + */
    + if (hw->mac.type >= ixgbe_mac_X550)
    + mrqc |= IXGBE_MRQC_L3L4TXSWEN;
    } else {
    if (tcs > 4)
    mrqc = IXGBE_MRQC_RTRSS8TCEN;
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-03-22 13:45    [W:2.903 / U:1.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site