lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 201/238] perf tools: Fix split_kallsyms_for_kcore() for trampoline symbols
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Adrian Hunter <adrian.hunter@intel.com>

    commit d6d457451eb94fa747dc202765592eb8885a7352 upstream.

    Kallsyms symbols do not have a size, so the size becomes the distance to
    the next symbol.

    Consequently the recently added trampoline symbols end up with large
    sizes because the trampolines are some distance from one another and the
    main kernel map.

    However, symbols that end outside their map can disrupt the symbol tree
    because, after mapping, it can appear incorrectly that they overlap
    other symbols.

    Add logic to truncate symbol size to the end of the corresponding map.

    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Cc: stable@vger.kernel.org
    Fixes: d83212d5dd67 ("kallsyms, x86: Export addresses of PTI entry trampolines")
    Link: http://lkml.kernel.org/r/20190109091835.5570-2-adrian.hunter@intel.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/util/symbol.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -710,6 +710,8 @@ static int map_groups__split_kallsyms_fo
    }

    pos->start -= curr_map->start - curr_map->pgoff;
    + if (pos->end > curr_map->end)
    + pos->end = curr_map->end;
    if (pos->end)
    pos->end -= curr_map->start - curr_map->pgoff;
    symbols__insert(&curr_map->dso->symbols, pos);

    \
     
     \ /
      Last update: 2019-03-22 13:23    [W:4.107 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site