lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 151/280] regulator: max77620: Initialize values for DT properties
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mark Zhang <markz@nvidia.com>

    commit 0ab66b3c326ef8f77dae9f528118966365757c0c upstream.

    If regulator DT node doesn't exist, its of_parse_cb callback
    function isn't called. Then all values for DT properties are
    filled with zero. This leads to wrong register update for
    FPS and POK settings.

    Signed-off-by: Jinyoung Park <jinyoungp@nvidia.com>
    Signed-off-by: Mark Zhang <markz@nvidia.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/regulator/max77620-regulator.c | 10 +++++++++-
    1 file changed, 9 insertions(+), 1 deletion(-)

    --- a/drivers/regulator/max77620-regulator.c
    +++ b/drivers/regulator/max77620-regulator.c
    @@ -1,7 +1,7 @@
    /*
    * Maxim MAX77620 Regulator driver
    *
    - * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
    + * Copyright (c) 2016-2018, NVIDIA CORPORATION. All rights reserved.
    *
    * Author: Mallikarjun Kasoju <mkasoju@nvidia.com>
    * Laxman Dewangan <ldewangan@nvidia.com>
    @@ -803,6 +803,14 @@ static int max77620_regulator_probe(stru
    rdesc = &rinfo[id].desc;
    pmic->rinfo[id] = &max77620_regs_info[id];
    pmic->enable_power_mode[id] = MAX77620_POWER_MODE_NORMAL;
    + pmic->reg_pdata[id].active_fps_src = -1;
    + pmic->reg_pdata[id].active_fps_pd_slot = -1;
    + pmic->reg_pdata[id].active_fps_pu_slot = -1;
    + pmic->reg_pdata[id].suspend_fps_src = -1;
    + pmic->reg_pdata[id].suspend_fps_pd_slot = -1;
    + pmic->reg_pdata[id].suspend_fps_pu_slot = -1;
    + pmic->reg_pdata[id].power_ok = -1;
    + pmic->reg_pdata[id].ramp_rate_setting = -1;

    ret = max77620_read_slew_rate(pmic, id);
    if (ret < 0)

    \
     
     \ /
      Last update: 2019-03-22 13:04    [W:2.948 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site