lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 167/183] md: Fix failed allocation of md_register_thread
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aditya Pakki <pakki001@umn.edu>

    commit e406f12dde1a8375d77ea02d91f313fb1a9c6aec upstream.

    mddev->sync_thread can be set to NULL on kzalloc failure downstream.
    The patch checks for such a scenario and frees allocated resources.

    Committer node:

    Added similar fix to raid5.c, as suggested by Guoqing.

    Cc: stable@vger.kernel.org # v3.16+
    Acked-by: Guoqing Jiang <gqjiang@suse.com>
    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: Song Liu <songliubraving@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/raid10.c | 2 ++
    drivers/md/raid5.c | 2 ++
    2 files changed, 4 insertions(+)

    --- a/drivers/md/raid10.c
    +++ b/drivers/md/raid10.c
    @@ -3821,6 +3821,8 @@ static int raid10_run(struct mddev *mdde
    set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
    mddev->sync_thread = md_register_thread(md_do_sync, mddev,
    "reshape");
    + if (!mddev->sync_thread)
    + goto out_free_conf;
    }

    return 0;
    --- a/drivers/md/raid5.c
    +++ b/drivers/md/raid5.c
    @@ -7370,6 +7370,8 @@ static int raid5_run(struct mddev *mddev
    set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
    mddev->sync_thread = md_register_thread(md_do_sync, mddev,
    "reshape");
    + if (!mddev->sync_thread)
    + goto abort;
    }

    /* Ok, everything is just fine now */

    \
     
     \ /
      Last update: 2019-03-22 12:57    [W:4.136 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site