Messages in this thread | | | Subject | Re: [PATCH] firmware: arm_scmi: check return value of idr_find | From | Kangjie Lu <> | Date | Fri, 22 Mar 2019 21:18:19 -0500 |
| |
> On Mar 8, 2019, at 10:02 PM, Kangjie Lu <kjlu@umn.edu> wrote: > > idr_find may return NULL, so check its return value and return an > error code.
Can someone review this patch? Thanks.
> > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/firmware/arm_scmi/driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 8f952f2f1a29..35faa203d549 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -709,6 +709,8 @@ scmi_mbox_chan_setup(struct scmi_info *info, struct device *dev, int prot_id) > > if (scmi_mailbox_check(np)) { > cinfo = idr_find(&info->tx_idr, SCMI_PROTOCOL_BASE); > + if (!cinfo) > + return -EINVAL; > goto idr_alloc; > } > > -- > 2.17.1 >
| |