lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/urgent] perf data: Don't store auxtrace index for directory data file
    Commit-ID:  cd3dd8dd8ff62374d90cb3f2e54b8c94106c7810
    Gitweb: https://git.kernel.org/tip/cd3dd8dd8ff62374d90cb3f2e54b8c94106c7810
    Author: Jiri Olsa <jolsa@kernel.org>
    AuthorDate: Fri, 8 Mar 2019 14:47:36 +0100
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Mon, 11 Mar 2019 11:56:03 -0300

    perf data: Don't store auxtrace index for directory data file

    We can't store the auxtrace index when we store into multiple files,
    because we keep only offset for it, not the file.

    The auxtrace data will be processed correctly in the 'pipe' mode.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/20190308134745.5057-3-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-record.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index f3f7f3100336..e983c8d71a79 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -392,7 +392,7 @@ static int record__process_auxtrace(struct perf_tool *tool,
    size_t padding;
    u8 pad[8] = {0};

    - if (!perf_data__is_pipe(data)) {
    + if (!perf_data__is_pipe(data) && !perf_data__is_dir(data)) {
    off_t file_offset;
    int fd = perf_data__fd(data);
    int err;
    \
     
     \ /
      Last update: 2019-03-22 23:04    [W:3.078 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site