Messages in this thread | | | Date | Fri, 22 Mar 2019 22:25:57 +0100 | From | Andrew Lunn <> | Subject | Re: [BISECTED, REGRESSION] Broken networking on MIPS/OCTEON EdgeRouter Lite |
| |
> The OCTEON HW code knows only about RGMII. And looking at > octeon ethernet staging driver it does phy connect always with > PHY_INTERFACE_MODE_GMII. I did some experimentation, and it seems that > with PHY_INTERFACE_MODE_RGMII_RXID it starts to work.. In the DT we have > for ethernet for this board: > > rx-delay = <0>; > tx-delay = <0x10>;
These are not PHY properties.
Looking at the code, it looks like these control delays the MAC inserts. I don't see a binding document for these properties, so i've no idea what 0x10 means. Before this driver moves out of staging, these values should be changed to be in ns.
However, PHY_INTERFACE_MODE_RGMII_RXID would make sense if 0x10 is sufficient to add the TX delay.
What the driver should however do is call of_of_get_phy_mode() to get the phy-mode from the DT blob and pass that to of_phy_connect().
Andrew
| |