lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static
On Fri, Mar 22, 2019 at 10:26:59PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> kernel/rcu/tree.c:2643:1: warning:
> symbol 'rcu_check_gp_start_stall' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Good eyes!

But someone beat you to this. Please see branch "dev" of -rcu:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

Thanx, Paul

> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index acd6ccf..ed3ef40 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2639,7 +2639,7 @@ EXPORT_SYMBOL_GPL(rcu_force_quiescent_state);
> * This function checks for grace-period requests that fail to motivate
> * RCU to come out of its idle mode.
> */
> -void
> +static void
> rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
> const unsigned long gpssdelay)
> {
> --
> 2.7.0
>
>

\
 
 \ /
  Last update: 2019-03-22 17:40    [W:0.034 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site