lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[BACKPORT 4.4.y 12/25] mm/rmap: replace BUG_ON(anon_vma->degree) with VM_WARN_ON
    Date
    From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

    This check effectively catches anon vma hierarchy inconsistence and some
    vma corruptions. It was effective for catching corner cases in anon vma
    reusing logic. For now this code seems stable so check could be hidden
    under CONFIG_DEBUG_VM and replaced with WARN because it's not so fatal.

    Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
    Suggested-by: Vasily Averin <vvs@virtuozzo.com>
    Acked-by: Vlastimil Babka <vbabka@suse.cz>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    (cherry picked from commit e4c5800a3991f0c6a766983535dfc10d51802cf6)
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    mm/rmap.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/rmap.c b/mm/rmap.c
    index 488dda209431..cf733fab230f 100644
    --- a/mm/rmap.c
    +++ b/mm/rmap.c
    @@ -408,7 +408,7 @@ void unlink_anon_vmas(struct vm_area_struct *vma)
    list_for_each_entry_safe(avc, next, &vma->anon_vma_chain, same_vma) {
    struct anon_vma *anon_vma = avc->anon_vma;

    - BUG_ON(anon_vma->degree);
    + VM_WARN_ON(anon_vma->degree);
    put_anon_vma(anon_vma);

    list_del(&avc->same_vma);
    --
    2.20.0
    \
     
     \ /
      Last update: 2019-03-22 16:48    [W:4.000 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site