Messages in this thread | | | From | Evan Green <> | Date | Fri, 22 Mar 2019 08:37:27 -0700 | Subject | Re: [PATCH 1/2] mfd: cros_ec: Add host_sleep_event_v1 command |
| |
On Thu, Mar 21, 2019 at 2:31 PM Enric Balletbo Serra <eballetbo@gmail.com> wrote: > > Hi Evan,Thanks for sending this upstream, one comment below. > Missatge de Evan Green <evgreen@chromium.org> del dia dc., 20 de març > 2019 a les 22:24: > > > > Introduce the command and response structures for the second revision > > of the host sleep event. These structures are part of a new EC change > > that enables detection of failure to enter S0ix. The EC waits a > > kernel-specified timeout (or a default amount of time) for the S0_SLP > > pin to change, and wakes the system if that change does not occur in > > time. > > > > Signed-off-by: Evan Green <evgreen@chromium.org> > > > > --- > > > > include/linux/mfd/cros_ec_commands.h | 59 ++++++++++++++++++++++++++++ > > We're trying to sync kernel cros_ec_commands.h with the EC protocol at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > Gwendal send a first patch [1] and a second version will be sent soon. > I don't see these definitions in the mentioned patch neither the > master ec_commands.h from the EC firmware repository. Is this a > feature that didn't land in the EC firmware yet? > > [1] https://lkml.org/lkml/2019/2/27/723 > > Thanks, > Enric
Hi Enric, That's correct, this feature is hot off the presses. It's being reviewed here, I expect it to land soon: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1501512
It seems like it would be easier if I based this series on top of Gwendal's. I'll plan to do that for the next spin unless I hear otherwise. -Evan
-Evan
| |