Messages in this thread | | | Date | Fri, 22 Mar 2019 06:33:30 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 4/5] RISC-V: Remove redundant trampoline page table |
| |
> > - /* Compute satp for kernel page tables, but don't load it yet */ > + /* Compute satp for kernel page directory, but don't load it yet */
> /* > - * Load trampoline page directory, which will cause us to trap to > + * Load kernel page directory, which will cause us to trap to > * stvec if VA != PA, or simply fall through if VA == PA > */
If we want to nitpick comments I think this should take about the page table root or something like that.
Otherwise the idea looks good, but I really think we should do this before all the changes to the setup_vm code.
| |