lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 032/183] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit c969c6e7ab8cb42b5c787c567615474fdbad9d6a ]

    The of_find_device_by_node() takes a reference to the underlying device
    structure, we should release that reference.

    Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
    index 51d42d7f6074..7e82dfbb4340 100644
    --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
    @@ -3074,6 +3074,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
    dsaf_dev = dev_get_drvdata(&pdev->dev);
    if (!dsaf_dev) {
    dev_err(&pdev->dev, "dsaf_dev is NULL\n");
    + put_device(&pdev->dev);
    return -ENODEV;
    }

    @@ -3081,6 +3082,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
    if (AE_IS_VER1(dsaf_dev->dsaf_ver)) {
    dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n",
    dsaf_dev->ae_dev.name);
    + put_device(&pdev->dev);
    return -ENODEV;
    }

    --
    2.19.1


    \
     
     \ /
      Last update: 2019-03-22 13:58    [W:4.156 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site