lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 001/280] media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

    commit 5e99456c20f712dcc13d9f6ca4278937d5367355 upstream.

    Userspace shouldn't set bytesused to 0 for output buffers.
    vb2_warn_zero_bytesused() warns about this (only once!), but it also
    calls WARN_ON(1), which is confusing since it is not immediately clear
    that it warns about a 0 value for bytesused.

    Just drop the WARN_ON as it serves no purpose.

    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Acked-by: Ezequiel Garcia <ezequiel@collabora.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Cc: Matthias Maennich <maennich@google.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/common/videobuf2/videobuf2-v4l2.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
    +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
    @@ -145,7 +145,6 @@ static void vb2_warn_zero_bytesused(stru
    return;

    check_once = true;
    - WARN_ON(1);

    pr_warn("use of bytesused == 0 is deprecated and will be removed in the future,\n");
    if (vb->vb2_queue->allow_zero_bytesused)

    \
     
     \ /
      Last update: 2019-03-22 13:49    [W:4.267 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site