lkml.org 
[lkml]   [2019]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/17] x86: Don't inline __const_udelay
    Date
    From: Andi Kleen <ak@linux.intel.com>

    __const_udelay is marked inline, and LTO will happily inline it everywhere
    Dropping the inline saves ~44k text in a LTO build.

    13999560 1740864 1499136 17239560 1070e08 vmlinux-with-udelay-inline
    13954764 1736768 1499136 17190668 1064f0c vmlinux-wo-udelay-inline

    Even without LTO I believe marking it noinline documents it correctly.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    ---
    arch/x86/lib/delay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c
    index f5b7f1b3b6d7..b7375dc6898f 100644
    --- a/arch/x86/lib/delay.c
    +++ b/arch/x86/lib/delay.c
    @@ -162,7 +162,7 @@ void __delay(unsigned long loops)
    }
    EXPORT_SYMBOL(__delay);

    -void __const_udelay(unsigned long xloops)
    +noinline void __const_udelay(unsigned long xloops)
    {
    unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy;
    int d0;
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-03-21 23:02    [W:4.304 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site