Messages in this thread | | | From | David Howells <> | Subject | Re: [RFC PATCH 4/8] vfs: Convert pstore to fs_context | Date | Thu, 21 Mar 2019 17:03:10 +0000 |
| |
Kees Cook <keescook@chromium.org> wrote:
> Why the separation between parse and apply now? Is this due to the > reconfigure calls? (i.e. why not call pstore_set_kmsg_bytes() in > pstore_parse_param()?
Because parameter parsing is now done up front, before the creation of the superblock of the invocation of the reconfigure method - so there's still a bunch of places that can error out before you know you're going to be successful in creating/reconfiguring the superblock.
David
| |