Messages in this thread | | | Subject | Re: [RFC PATCH nand-next 0/2] meson-nand: support for older SoCs | From | Liang Yang <> | Date | Thu, 21 Mar 2019 20:10:25 +0800 |
| |
Hi Martin,
On 2019/3/21 4:48, Martin Blumenstingl wrote: > Hi Liang, > > On Wed, Mar 20, 2019 at 4:32 AM Liang Yang <liang.yang@amlogic.com> wrote: >> >> Hi Martin, >> >> Thanks for your time. >> On 2019/3/20 4:27, Martin Blumenstingl wrote: >>> Hello Liang, >>> >>> On Sat, Mar 16, 2019 at 11:55 AM Martin Blumenstingl >>> <martin.blumenstingl@googlemail.com> wrote: >>> [...] > >> Allocating a fixed size info buffer before nand_scan_ident and attach it >> on the struct meson_nfc; Or considering not use dma for reading data >> less than 8 bytes. Both can reduce kmalloc and kfree calling. Thanks. > both suggestions sound reasonable. > however, I will search for the root cause of the unaligned address > first before changing the Meson NFC driver. That is good. And i will implement one of both mentioned above soon. > > [...] >>> [ 2.227374] ------------[ cut here ]------------ >>> [ 2.231968] WARNING: CPU: 1 PID: 1 at >>> drivers/mtd/nand/raw/nand_base.c:5503 nand_scan_with_ids+0x1718/0x171c >>> [ 2.241760] No oob scheme defined for oobsize 1280 >>> ... >>> (the "No oob scheme defined for oobsize 1280" message is expected) >>> >> miss mtd_set_ooblayout(mtd, &meson_ooblayout_ops) on function >> meson_nand_attach_chip. > thank you for the suggestion. I didn't have time to test this on my > board yet but I'll let you know about my results during the weekend. > Does the missing mtd_set_ooblayout() call also affect GXL or AXG boards? > Yes. I deleted it unintentionally. > > Regards > Martin > > . >
| |