lkml.org 
[lkml]   [2019]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] powerpc/8xx: fix possible object reference leak
    Date
    The call to of_find_compatible_node returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.
    irq_domain_add_linear also calls of_node_get to increase refcount,
    so irq_domain will not be affected when it is released.

    Detected by coccinelle with the following warnings:
    ./arch/powerpc/platforms/8xx/pic.c:158:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 136, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Vitaly Bordug <vitb@kernel.crashing.org>
    Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: linuxppc-dev@lists.ozlabs.org
    Cc: linux-kernel@vger.kernel.org
    ---
    arch/powerpc/platforms/8xx/pic.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/8xx/pic.c b/arch/powerpc/platforms/8xx/pic.c
    index 8d5a25d..13d880b 100644
    --- a/arch/powerpc/platforms/8xx/pic.c
    +++ b/arch/powerpc/platforms/8xx/pic.c
    @@ -155,6 +155,7 @@ int mpc8xx_pic_init(void)
    ret = -ENOMEM;
    goto out;
    }
    + of_node_put(np);
    return 0;

    out:
    --
    2.9.5
    \
     
     \ /
      Last update: 2019-03-22 04:09    [W:4.652 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site