Messages in this thread | | | Subject | Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static | From | Mukesh Ojha <> | Date | Thu, 21 Mar 2019 02:15:15 +0530 |
| |
On 3/20/2019 7:52 PM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warnings: > > drivers/irqchip/irq-brcmstb-l2.c:278:12: warning: > symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static? > drivers/irqchip/irq-brcmstb-l2.c:285:12: warning: > symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/irqchip/irq-brcmstb-l2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c > index 83364fe..5e4ca13 100644 > --- a/drivers/irqchip/irq-brcmstb-l2.c > +++ b/drivers/irqchip/irq-brcmstb-l2.c > @@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np, > return ret; > } > > -int __init brcmstb_l2_edge_intc_of_init(struct device_node *np, > +static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np, > struct device_node *parent) > { > return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init); > } > IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init); > > -int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np, > +static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np, > struct device_node *parent) > { > return
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks, Mukesh
> brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
| |