Messages in this thread | | | Subject | Re: dell_smbios KASAN bug | From | Tom Zanussi <> | Date | Wed, 20 Mar 2019 15:28:56 -0500 |
| |
On Wed, 2019-03-20 at 15:45 -0400, Steven Rostedt wrote: > On Wed, 20 Mar 2019 14:30:21 -0500 > Tom Zanussi <tzanussi@gmail.com> wrote: > > > > diff --git a/drivers/platform/x86/dell-smbios-base.c > > > b/drivers/platform/x86/dell-smbios-base.c > > > index 9dc282ed5a9e..c3825c674522 100644 > > > --- a/drivers/platform/x86/dell-smbios-base.c > > > +++ b/drivers/platform/x86/dell-smbios-base.c > > > @@ -619,6 +619,7 @@ static int __init dell_smbios_init(void) > > > > > > fail_platform_driver: > > > kfree(da_tokens); > > > + da_num_tokens = 0; > > > return ret; > > > } > > > > > > > > > Unfortunately, no. > > That's really weird. I would recommend throwing in a bunch of printks > to see if things are being freed and set, to make sure this code is > hit > and something else isn't just corrupting it. >
Actually the patch does make the KASAN bug go away - I'm so used to building without modules that I forgot to rebuild the module after applying the patch, sigh.
Tom
> -- Steve
| |