lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Xen-devel] [PATCH] PCI: Mark expected switch fall-throughs
    From
    Date
    On 20/03/2019 18:27, Gustavo A. R. Silva wrote:
    > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
    > index 6fa1627ce08d..445b51db75b0 100644
    > --- a/drivers/pci/proc.c
    > +++ b/drivers/pci/proc.c
    > @@ -222,6 +222,7 @@ static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
    > }
    > /* If arch decided it can't, fall through... */
    > #endif /* HAVE_PCI_MMAP */
    > + /* fall through */

    Surely it would be better to transpose the #endif and its previous line,
    than to add a second fallthrough ?

    ~Andrew

    \
     
     \ /
      Last update: 2019-03-20 20:28    [W:2.409 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site