Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] PCI: Mark expected switch fall-throughs | From | Andrew Cooper <> | Date | Wed, 20 Mar 2019 19:27:32 +0000 |
| |
On 20/03/2019 18:27, Gustavo A. R. Silva wrote: > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 6fa1627ce08d..445b51db75b0 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -222,6 +222,7 @@ static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd, > } > /* If arch decided it can't, fall through... */ > #endif /* HAVE_PCI_MMAP */ > + /* fall through */
Surely it would be better to transpose the #endif and its previous line, than to add a second fallthrough ?
~Andrew
| |