lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/25] coresight: tmc: Report DMA setup failures
    Date
    If we failed to setup the DMA mask for TMC-ETR, report the
    error before failing the probe.

    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    ---
    drivers/hwtracing/coresight/coresight-tmc.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
    index 2a02da3..647b6aa 100644
    --- a/drivers/hwtracing/coresight/coresight-tmc.c
    +++ b/drivers/hwtracing/coresight/coresight-tmc.c
    @@ -340,6 +340,8 @@ static inline bool tmc_etr_can_use_sg(struct tmc_drvdata *drvdata)
    static int tmc_etr_setup_caps(struct tmc_drvdata *drvdata,
    u32 devid, void *dev_caps)
    {
    + int rc;
    +
    u32 dma_mask = 0;

    /* Set the unadvertised capabilities */
    @@ -369,7 +371,10 @@ static int tmc_etr_setup_caps(struct tmc_drvdata *drvdata,
    dma_mask = 40;
    }

    - return dma_set_mask_and_coherent(drvdata->dev, DMA_BIT_MASK(dma_mask));
    + rc = dma_set_mask_and_coherent(drvdata->dev, DMA_BIT_MASK(dma_mask));
    + if (rc)
    + dev_err(drvdata->dev, "Failed to setup DMA mask: %d\n", rc);
    + return rc;
    }

    static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-03-20 19:51    [W:3.063 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site