lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net:mwl8k:move spin_lock_bh to spin_lock in tasklet
Is it possible that this solves this long standing issue? :
https://www.spinics.net/lists/linux-wireless/msg151171.html
Bye

Il giorno mar 19 mar 2019 alle ore 17:25 Jeff Xie
<chongguiguzi@gmail.com> ha scritto:
>
> It is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> ---
> drivers/net/wireless/marvell/mwl8k.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c
> index 8e4e9b6..21a86cc 100644
> --- a/drivers/net/wireless/marvell/mwl8k.c
> +++ b/drivers/net/wireless/marvell/mwl8k.c
> @@ -4631,7 +4631,7 @@ static void mwl8k_tx_poll(unsigned long data)
>
> limit = 32;
>
> - spin_lock_bh(&priv->tx_lock);
> + spin_lock(&priv->tx_lock);
>
> for (i = 0; i < mwl8k_tx_queues(priv); i++)
> limit -= mwl8k_txq_reclaim(hw, i, limit, 0);
> @@ -4641,7 +4641,7 @@ static void mwl8k_tx_poll(unsigned long data)
> priv->tx_wait = NULL;
> }
>
> - spin_unlock_bh(&priv->tx_lock);
> + spin_unlock(&priv->tx_lock);
>
> if (limit) {
> writel(~MWL8K_A2H_INT_TX_DONE,
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-03-20 08:09    [W:0.064 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site