Messages in this thread | | | Subject | Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference | From | Mukesh Ojha <> | Date | Wed, 20 Mar 2019 18:42:45 +0530 |
| |
On 3/13/2019 9:43 PM, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> > --- > drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/rtlwifi/phydm/rtl_phydm.c b/drivers/staging/rtlwifi/phydm/rtl_phydm.c > index 9930ed954abb..37c7fcb72b65 100644 > --- a/drivers/staging/rtlwifi/phydm/rtl_phydm.c > +++ b/drivers/staging/rtlwifi/phydm/rtl_phydm.c > @@ -181,6 +181,9 @@ static int rtl_phydm_init_priv(struct rtl_priv *rtlpriv, > rtlpriv->phydm.internal = > kzalloc(sizeof(struct phy_dm_struct), GFP_KERNEL); > > + if (!rtlpriv->phydm.internal) > + return -ENOMEM; > +
Although, it is good to add a check but nobody is checking this functions returned value.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Can you fix that cleanly ? Otherwise i will do.
Cheers, Mukesh
> _rtl_phydm_init_com_info(rtlpriv, ic, params); > > odm_init_all_timers(dm);
| |