lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: netlogic: replace skb_put/pull pair with skb_reserve
    Date
    The sequence

    skb_put(skb);
    skb_pull(skb);

    leads to the same result as

    skb_reserve(skb);

    but second is a little shorter and clearer.

    Signed-off-by: Ivan Safonov <insafonov@gmail.com>
    ---
    drivers/staging/netlogic/xlr_net.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
    index 10f14a5cf490..1897b711d66d 100644
    --- a/drivers/staging/netlogic/xlr_net.c
    +++ b/drivers/staging/netlogic/xlr_net.c
    @@ -87,8 +87,7 @@ static inline unsigned char *xlr_alloc_skb(void)
    if (!skb)
    return NULL;
    skb_data = skb->data;
    - skb_put(skb, MAC_SKB_BACK_PTR_SIZE);
    - skb_pull(skb, MAC_SKB_BACK_PTR_SIZE);
    + skb_reserve(skb, MAC_SKB_BACK_PTR_SIZE);
    memcpy(skb_data, &skb, buf_len);

    return skb->data;
    --
    2.19.2
    \
     
     \ /
      Last update: 2019-03-20 13:43    [W:3.462 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site