lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 5/5] arm64: dts: rockchip: Enable dmc and dfi nodes on gru.
    From
    Date
    Hi Gaël,

    On 19. 3. 20. 오전 3:13, Gaël PORTAY wrote:
    > From: Lin Huang <hl@rock-chips.com>
    >
    > Enable the DMC (Dynamic Memory Controller) and the DFI (DDR PHY Interface)
    > nodes on gru/kevin boards so we can support DDR DVFS.
    >
    > Signed-off-by: Lin Huang <hl@rock-chips.com>
    > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    > Signed-off-by: Gaël PORTAY <gael.portay@collabora.com>
    > ---
    >
    > Changes in v2:
    > - [PATCH 8/8] Move center-supply attribute of dmc node in file
    > rk3399-gru-chromebook.dtsi (where ppvar_centerlogic is
    > defined).
    >
    > Changes in v1: None
    >
    > .../dts/rockchip/rk3399-gru-chromebook.dtsi | 4 ++++
    > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 20 +++++++++++++++++++
    > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +-
    > 3 files changed, 25 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    > index 931640e9aed4..cfb81356c61e 100644
    > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi
    > @@ -400,3 +400,7 @@ ap_i2c_tp: &i2c5 {
    > rockchip,pins = <0 8 RK_FUNC_GPIO &pcfg_pull_none>;
    > };
    > };
    > +
    > +&dmc {
    > + center-supply = <&ppvar_centerlogic>;
    > +};
    > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
    > index da03fa9c5662..d14dce679e7a 100644
    > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
    > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
    > @@ -289,6 +289,12 @@
    > status = "okay";
    > };
    >
    > +&dmc_opp_table {
    > + opp04 {
    > + opp-suspend;
    > + };
    > +};
    > +
    > /*
    > * Set some suspend operating points to avoid OVP in suspend
    > *
    > @@ -368,6 +374,10 @@
    > <200000000>;
    > };
    >
    > +&display_subsystem {
    > + devfreq = <&dmc>;
    > +};

    When I checked the rockchip_drm_drv.c on linux-next.git (20190320),
    there are no any codes about this. Maybe it should be removed.

    > +
    > &emmc_phy {
    > status = "okay";
    > };
    > @@ -489,6 +499,16 @@ ap_i2c_audio: &i2c8 {
    > status = "okay";
    > };
    >
    > +&dfi {
    > + status = "okay";
    > +};
    > +
    > +&dmc {
    > + status = "okay";
    > + upthreshold = <25>;
    > + downdifferential = <15>;
    > +};
    > +
    > &sdhci {
    > /*
    > * Signal integrity isn't great at 200 MHz and 150 MHz (DDR) gives the
    > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
    > index 8fe86a3e7658..010b3e5267a0 100644
    > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
    > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
    > @@ -156,7 +156,7 @@
    > };
    > };
    >
    > - display-subsystem {
    > + display_subsystem: display-subsystem {
    > compatible = "rockchip,display-subsystem";
    > ports = <&vopl_out>, <&vopb_out>;
    > };
    >


    --
    Best Regards,
    Chanwoo Choi
    Samsung Electronics

    \
     
     \ /
      Last update: 2019-03-20 06:06    [W:2.426 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site