Messages in this thread | | | Subject | Re: [Intel-wired-lan] [PATCH net-next] igc: Make igc_write_rss_indir_tbl static | From | YueHaibing <> | Date | Wed, 20 Mar 2019 15:52:11 +0800 |
| |
On 2019/3/20 15:07, Neftin, Sasha wrote: > On 3/19/2019 16:55, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> >> Fix sparse warning: >> >> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: >> warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c >> index eff37a6..5442394 100644 >> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c >> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c >> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev, >> return 0; >> } >> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter) >> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter) >> { >> struct igc_hw *hw = &adapter->hw; >> u32 reg = IGC_RETA(0); >> > The 'igc_write_rss_indir_tbl' method is declared in igc.h and used in igc_main.c > Please, refer to latest Jeff next-queue, there is latest patches used these methods.
Well, I did not refer to Jeff's tree. So this patch can be dropped.
Thanks!
> > . >
| |