Messages in this thread Patch in this message | | | From | Aditya Pakki <> | Subject | [PATCH] thunderbolt: Fix to check the return value of kmemdup | Date | Tue, 19 Mar 2019 13:38:34 -0500 |
| |
uuid in add_switch is allocted via kmemdup which can fail. The patch logs the error in such a scenario.
Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/thunderbolt/icm.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c index e3fc920af682..8df8057cd79e 100644 --- a/drivers/thunderbolt/icm.c +++ b/drivers/thunderbolt/icm.c @@ -473,6 +473,7 @@ static void add_switch(struct tb_switch *parent_sw, u64 route, goto out; sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL); + WARN_ONCE(!sw->uuid, "%s: sw->uuid = NULL", __func__); sw->connection_id = connection_id; sw->connection_key = connection_key; sw->link = link; -- 2.17.1
| |