Messages in this thread | | | Date | Tue, 19 Mar 2019 17:52:08 +0100 | From | Greg KH <> | Subject | Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier |
| |
On Tue, Mar 19, 2019 at 09:14:32AM -0700, Roman Kiryanov wrote: > Hi, I am sorry for this warning. I remember I checked all changes I > sent, maybe missed this one. > > At the bottom the file says > > MODULE_LICENSE("GPL"); > > and > > // SPDX-License-Identifier: GPL-2.0 > > makes it inconsistent.
No, please read include/linux/module.h in 5.1-rc1, that nightmare is now fixed up.
Also, you were inconsistent from the beginning with the text at the top of the file, so that was your issue to start with :)
Also, please do not top post.
thanks,
greg k-h
| |