lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/19] locking/lockdep: Update obsolete struct field description
On Tue, Mar 19, 2019 at 09:35:49AM -0700, Bart Van Assche wrote:
> On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote:
> > struct lock_chain {
> > - /* see BUILD_BUG_ON()s in lookup_chain_cache() */

That's add_chain_cache() now, please do keep the reference.

> > + /*
> > + * irq_context: the same as irq_context in held_lock below
> > + * depth: the number of held locks in this chain
> > + * base: the index in chain_hlocks for this chain
> > + */
> > unsigned int irq_context : 2,
> > depth : 6,
> > base : 24;
>
> Have you considered to use the kernel-doc style for documenting these
> structure members?
>
> Thanks,
>
> Bart.

\
 
 \ /
  Last update: 2019-03-19 17:45    [W:0.066 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site