Messages in this thread | | | Subject | Re: [PATCH v2 19/19] locking/lockdep: Change if to else-if when checking bfs errors | From | Bart Van Assche <> | Date | Tue, 19 Mar 2019 09:29:27 -0700 |
| |
On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote: > - if (ret < 0) { > + if (unlikely(ret < 0)) { > print_bfs_bug(ret); > return 0; > } > - if (ret == 1) > + else if (ret == 1) > return ret;
Have you verified this patch series with checkpatch? Checkpatch should have reported that you are changing code that conforms to the coding style into code that does not conform to the kernel coding style. Checkpatch should have reported the following:
"else is not generally useful after a break or return"
Thanks,
Bart.
| |