lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] tools/power turbostat: return the exit status of a command
Acked-by: Len Brown <len.brown@intel.com>

On Wed, Feb 20, 2019 at 5:55 AM David Arcari <darcari@redhat.com> wrote:
>
>
> ping -- just want to make sure this doesn't get lost.
>
> Thanks!
>
> On 02/12/2019 09:34 AM, David Arcari wrote:
> > turbostat failed to return a non-zero exit status even though the
> > supplied command (turbostat <command>) failed. Currently when turbostat
> > forks a command it returns zero instead of the actual exit status of the
> > command. Modify the code to return the exit status.
> >
> > Signed-off-by: David Arcari <darcari@redhat.com>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Jirka Hladky <jhladky@redhat.com>
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > tools/power/x86/turbostat/turbostat.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> > index 9327c0d..c3fad06 100644
> > --- a/tools/power/x86/turbostat/turbostat.c
> > +++ b/tools/power/x86/turbostat/turbostat.c
> > @@ -5077,6 +5077,9 @@ int fork_it(char **argv)
> > signal(SIGQUIT, SIG_IGN);
> > if (waitpid(child_pid, &status, 0) == -1)
> > err(status, "waitpid");
> > +
> > + if (WIFEXITED(status))
> > + status = WEXITSTATUS(status);
> > }
> > /*
> > * n.b. fork_it() does not check for errors from for_all_cpus()
> >
>


--
Len Brown, Intel Open Source Technology Center

\
 
 \ /
  Last update: 2019-03-19 16:13    [W:0.104 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site