lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight support
On Tue, Mar 19, 2019 at 09:11:38AM +0000, Anson Huang wrote:
> Hi,
>
> Best Regards!
> Anson Huang
>
> > -----Original Message-----
> > From: Uwe Kleine-König [mailto:u.kleine-koenig@pengutronix.de]
> > Sent: 2019年3月19日 16:15
> > To: Anson Huang <anson.huang@nxp.com>
> > Cc: thierry.reding@gmail.com; robh+dt@kernel.org; mark.rutland@arm.com;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> > festevam@gmail.com; linux@armlinux.org.uk; stefan@agner.ch;
> > otavio@ossystems.com.br; Leonard Crestez <leonard.crestez@nxp.com>;
> > schnitzeltony@gmail.com; jan.tuerk@emtrion.com; Robin Gong
> > <yibin.gong@nxp.com>; linux-pwm@vger.kernel.org;
> > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> > Subject: Re: [PATCH RESEND V6 0/5] Add i.MX7ULP EVK PWM backlight
> > support
> >
> > On Tue, Mar 19, 2019 at 07:09:56AM +0000, Anson Huang wrote:
> > > i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by
> > > TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver
> > support
> > > and also add backlight support for MIPI-DSI display.
> >
> > Given that you actually changed something compared to v6, this is not a
> > resend but v7. Also I suggest to practise a bit of patience before sending out
> > a new revision to prevent people still looking at the previous round. I just
> > gave feedback to the original v6 which you obviously didn't address :-|
> >
> > Also a highlevel changelog for the series (here something like: "Properly
> > separate dt changes into soc-specific and machine-specific changes") is
> > helpful.
>
> OK, will pay attention to that, the resend is just because the patch content is NOT
> Changed, just re-organize the DT patch.
>
> Also, I understand that sending the patch version too quickly will result in too many
> Patch version in this thread, but I just want to address the comments ASAP when I
> Have time, hope that does NOT bother reviewer too much...

A middle way is to provide a git-tree somewhere and in reply to a review
just say: I updated the patches according to your feedback, but will
wait a bit more for further feedback before resending. If you're
interested the current work in progress can be found at git://... in the
xyz branch.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |

\
 
 \ /
  Last update: 2019-03-19 11:26    [W:0.041 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site