lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: usb251xb: Remove unnecessary comparison of unsigned integer with >= 0
From
Date

On 18/03/2019 17:48, Marco Felsch wrote:
> On 19-03-18 16:46, Richard Leitner wrote:
>> A small note on further improvement from my side:
>>
>> According the datasheet, when you set swap-dx-lanes to 0 (-> setting port to
>> 0 -> setting bit 0 of PRTSP) " the upstream port DP/DM is swapped".
>
> Yes I know that's not intuitve and may confuses the users.
>
>> IMHO this is not straight-forward, so maybe we want to additionally
>>
>> a) mention it somewhere in the documentation
>
> IMHO this is the correct place.
>
>> b) check on port >= 1
>
> I think this isn't doable since we shouldn't break the existing dt.

ACK.

@Marco/Gustavo: does one of you wants to provide a patch for this?

>
> Regards,
> Marco
>
>> c) something else?
>>
>> Any opinions on that from your side? ... I'd prefer "a"...

regards;Richard.L

\
 
 \ /
  Last update: 2019-03-19 10:41    [W:0.214 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site