Messages in this thread | | | From | Yuyang Du <> | Date | Wed, 20 Mar 2019 10:30:50 +0800 | Subject | Re: [PATCH v2 15/19] locking/lockdep: Remove __cq_empty() |
| |
Thanks for review.
On Wed, 20 Mar 2019 at 00:54, Bart Van Assche <bvanassche@acm.org> wrote: > > This is the most important change in this patch. Using the title "Remove __cq_empty()" > for this patch is misleading because the above patch does something else, namely changing > the return type of __cq_dequeue() from int into a pointer. Should this patch perhaps be > split or should the __cq_empty() removal be left out from this patch?
I actually hesitated whether _cq_full() should be inlined as well. Having said that, let me keep both of them and just change the return type of __cq_dequeue().
Thanks, Yuyang
| |