lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet
It was only called in the tasklet context.

root@jeff:~/git/linux-next# git grep -in bnxt_qplib_service_nq
drivers/infiniband/hw/bnxt_re/qplib_fp.c:236:static void
bnxt_qplib_service_nq(unsigned long data)
drivers/infiniband/hw/bnxt_re/qplib_fp.c:390:
tasklet_init(&nq->worker, bnxt_qplib_service_nq,


thanks.

Jason Gunthorpe <jgg@ziepe.ca> 于2019年3月20日周三 上午3:22写道:
>
> On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
> > ---
> > drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I'm curious, how did you prove this was always in a tasklet?
>
> Jason



--
jeff

\
 
 \ /
  Last update: 2019-03-20 01:49    [W:2.748 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site