Messages in this thread | | | Subject | Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static | From | Alexey Kardashevskiy <> | Date | Wed, 20 Mar 2019 11:39:17 +1100 |
| |
On 20/03/2019 17:47, Wang Hai wrote: > Fixes the following sparse warning: > > drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning: > symbol 'tce_iommu_driver_ops' was not declared. Should it be static? > > Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO") > Signed-off-by: Wang Hai <wanghai26@huawei.com>
I am curious - what exactly did you do to get this warning?
Anyway,
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> --- > drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c > index 8dbb270..6b64e45 100644 > --- a/drivers/vfio/vfio_iommu_spapr_tce.c > +++ b/drivers/vfio/vfio_iommu_spapr_tce.c > @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data, > mutex_unlock(&container->lock); > } > > -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { > .name = "iommu-vfio-powerpc", > .owner = THIS_MODULE, > .open = tce_iommu_open, >
-- Alexey
| |