Messages in this thread | | | Date | Mon, 18 Mar 2019 18:42:47 +0100 | From | Greg KH <> | Subject | Re: [PATCH] Add code to support USBIP Project for Windows |
| |
On Mon, Mar 18, 2019 at 09:37:28AM -0700, VizXu wrote: > Signed-off-by: VizXu <xujiweigo@163.com> > ---
I can not take patches without any changelog text, sorry.
Please fix up and resend so we have an idea of what this patch is for and why it is needed.
> drivers/usb/usbip/stub_dev.c | 4 ++++ > drivers/usb/usbip/stub_rx.c | 37 +++++++++++++++++++++++++++++++++++++ > drivers/usb/usbip/usbip_common.h | 16 ++++++++++++++++ > 3 files changed, 57 insertions(+) > > diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c > index c0d6ff1..be95c72 100644 > --- a/drivers/usb/usbip/stub_dev.c > +++ b/drivers/usb/usbip/stub_dev.c > @@ -270,6 +270,10 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev) > sdev->ud.tcp_socket = NULL; > sdev->ud.sockfd = -1; > > +#ifdef SUPPORT_WIN > + sdev->ud.is_configured = false; > +#endif
#ifdef should never be in a .c file if at all possible. Please rework this to use the proper style of doing this type of thing in a .h file.
thanks,
greg k-h
| |