| From | Linus Torvalds <> | Date | Mon, 18 Mar 2019 09:58:20 -0700 | Subject | Re: [PATCH 01/25] x86: Make SMAP 64-bit only |
| |
On Mon, Mar 18, 2019 at 8:54 AM Peter Zijlstra <peterz@infradead.org> wrote: > > We rely on objtool to verify AC=1 doesn't escape. However there is no > objtool support for x86_32, and thus we cannot guarantee the > correctness of the 32bit code.
Absolutely not.
This is just crazy. We had working SMAP long before objtool, and we will have it regardless of objtool.
This is like saying "ok, I don't have an oxygen sensor, so I don't know that the air I'm breathing is sufficient to maintain life, so I'll just stop breathing".
So no way in hell do we make SMAP go away on 32-bit for no sane reason what-so-ever.
Besides, the x86-64 objtool coverage will cover 99% of all 32-bit code too, simply because we share it. In fact, it will cover most of the code for other architectures too.
Linus
|