lkml.org 
[lkml]   [2019]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 07/45] drivers: tty: serial: 8250_uniphier: use devm_ioremap_resource()
    On Fri, Mar 15, 2019 at 7:35 AM Enrico Weigelt, metux IT consult
    <info@metux.net> wrote:
    >
    > Instead of fetching out data from a struct resource for passing
    > it to devm_ioremap(), directly use devm_ioremap_resource()
    >
    > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
    > ---


    NACK.


    This patch would break my driver.

    Probably, all the 8250* drivers would be broken in the same way.


    For 8250 drivers, request_mem_region() is called
    from 8250_port.c


    Let's not touch around the code you do not
    understand how it works.


    Thanks.

    Masahiro Yamada



    > drivers/tty/serial/8250/8250_uniphier.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
    > index 164ba13..9c1244e 100644
    > --- a/drivers/tty/serial/8250/8250_uniphier.c
    > +++ b/drivers/tty/serial/8250/8250_uniphier.c
    > @@ -171,7 +171,7 @@ static int uniphier_uart_probe(struct platform_device *pdev)
    > return -EINVAL;
    > }
    >
    > - membase = devm_ioremap(dev, regs->start, resource_size(regs));
    > + membase = devm_ioremap_resource(dev, regs);
    > if (!membase)
    > return -ENOMEM;
    >
    > --
    > 1.9.1
    >

    \
     
     \ /
      Last update: 2019-03-18 08:46    [W:4.428 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site