lkml.org 
[lkml]   [2019]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net] mac8390: Fix mmio access size probe
From
From: Finn Thain <fthain@telegraphics.com.au>
Date: Sat, 16 Mar 2019 14:21:19 +1100

> The bug that Stan reported is as follows. After a restart, a 16-bit NIC
> may be incorrectly identified as a 32-bit NIC and stop working.
>
> mac8390 slot.E: Memory length resource not found, probing
> mac8390 slot.E: Farallon EtherMac II-C (type farallon)
> mac8390 slot.E: MAC 00:00:c5:30:c2:99, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.
>
> The bug never arises after a cold start and only intermittently after a
> warm start. (I didn't investigate why the bug is intermittent.)
>
> It turns out that memcpy_toio() is deprecated and memcmp_withio() also
> has issues. Replacing these calls with mmio accessors fixes the problem.
>
> Reported-and-tested-by: Stan Johnson <userm57@yahoo.com>
> Fixes: 2964db0f5904 ("m68k: Mac DP8390 update")
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Applied and queued up for -stable, thanks.

\
 
 \ /
  Last update: 2019-03-19 01:00    [W:0.045 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site