Messages in this thread | | | From | Martin Blumenstingl <> | Date | Mon, 18 Mar 2019 21:17:39 +0100 | Subject | Re: [PATCH v2 08/11] arm64: dts: meson-g12a-sei510: Add ADC Key and BT support |
| |
On Mon, Mar 18, 2019 at 11:06 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Add support for the : > - ADC Touch key > - Bluetooth Module on UART A > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> I have no details about this board but the changes look sane, so (apart from one nit-pick below): Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> --- > .../boot/dts/amlogic/meson-g12a-sei510.dts | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts > index 43d57e20294a..ebdad5a192f1 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts > @@ -7,6 +7,7 @@ > > #include "meson-g12a.dtsi" > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > #include <dt-bindings/gpio/meson-g12a-gpio.h> > > / { > @@ -17,6 +18,19 @@ > serial0 = &uart_AO; > }; > > + adc_keys { in meson-gxm-khadas-vim2.dts we use "adc-keys". Other Allwinner and Rockchip board also use "adc-keys" instead of "adc_keys". I prefer if we go with "adc-keys" (we can clean up the two occurrences of "adc_keys" in arch/arm64/boot/dts/amlogic later)
Regards Martin
| |