Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 18 Mar 2019 10:05:47 +0100 | Subject | Re: Enabling -Wint-in-bool-context |
| |
On Mon, Mar 18, 2019 at 9:46 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Hi Arnd, > > I saw several commits from you > fixing -Wint-in-bool-context warnings. > Thanks! > > > I guess we are almost ready to remove > > KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context) > > > In there any concern about re-enabling > this warning? > > > When I asked 0-day bot to test it some days ago, > I just got a report > for drivers/net/ethernet/mellanox/mlxsw/. > > Perhaps, you may have better test coverage > and have noticed more warnings, though.
I had this enabled in my randconfig testing last year, but not after rebasing on linux-4.20. My plan was always to enable the warning (and a few others) eventually, but this was part of my idea for a larger-scale rework of how we handle warnings in the kernel, and I never got around to implementing that.
I've turned it on manually again now, will let you know if something comes up, but I expect that we can simply do it and fix any warnings as they come up.
Arnd
| |