Messages in this thread Patch in this message | | | From | Stephen Boyd <> | Subject | [PATCH v2] firmware: vpd: Drop __iomem usage for memremap() memory | Date | Mon, 18 Mar 2019 12:41:16 -0700 |
| |
memremap() doesn't return an iomem pointer, so we can just use memcpy() and drop the __iomem annotation here. This silences a sparse warning.
Cc: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Anton Vasilyev <vasilyev@ispras.ru> Signed-off-by: Stephen Boyd <swboyd@chromium.org> ---
Changes from v1: * Added RB and fixed signoff
drivers/firmware/google/vpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c index c0c0b4e4e281..f240946ed701 100644 --- a/drivers/firmware/google/vpd.c +++ b/drivers/firmware/google/vpd.c @@ -254,7 +254,7 @@ static int vpd_section_destroy(struct vpd_section *sec) static int vpd_sections_init(phys_addr_t physaddr) { - struct vpd_cbmem __iomem *temp; + struct vpd_cbmem *temp; struct vpd_cbmem header; int ret = 0; @@ -262,7 +262,7 @@ static int vpd_sections_init(phys_addr_t physaddr) if (!temp) return -ENOMEM; - memcpy_fromio(&header, temp, sizeof(struct vpd_cbmem)); + memcpy(&header, temp, sizeof(struct vpd_cbmem)); memunmap(temp); if (header.magic != VPD_CBMEM_MAGIC) -- Sent by a computer through tubes
| |