Messages in this thread Patch in this message | | | Date | Sun, 17 Mar 2019 11:14:35 +0100 | From | Greg KH <> | Subject | Re: [PATCH] staging: speakup: fix line over 80 characters. |
| |
On Sun, Mar 17, 2019 at 03:39:46AM +0000, Jules Irenge wrote: > Fix coding style issues, which solves checkpatch.pl warning: > "WARNING: line over 80 characters". > --- > drivers/staging/speakup/kobjects.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 2eb5af3debb3..abeab64899db 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, > continue; > } > > - /* Do not replace with kstrtoul: here we need temp to be updated */ > +/* Do not replace with kstrtoul: here we need temp to be updated */
No, never put code or comments this far to the left. Instead, properly line-wrap them.
thanks,
greg k-h
| |