Messages in this thread | | | From | Martin Blumenstingl <> | Date | Fri, 15 Mar 2019 22:40:46 +0100 | Subject | Re: [PATCH 8/9] arm64: dts: meson: g12a: Add G12A USB nodes |
| |
On Thu, Mar 7, 2019 at 4:15 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > This patch adds the nodes for the USB Complex found in the Amlogic > G12A SoC. > > It includes the : > - 2 USB2 PHYs > - 1 USB3 + PCIE Combo PHY > - the USB Glue with it's DWC2 and DWC3 sub-nodes > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[...] > + g-tx-fifo-size = <128 128 16 16 16>; I'm not sure about these values but it seems you have already successfully them. buildroot_openlinux_kernel_4.9_fbdev_20180706 uses the following values (which are identical to the ones on GXL/GXM, but using the values below I couldn't get dwc2 to work on GXL when I tried it last): dev_tx_fifo_size[0] = 128; dev_tx_fifo_size[1] = 128; dev_tx_fifo_size[2] = 128; dev_tx_fifo_size[3] = 16; dev_tx_fifo_size[4] = 16;
Thus I'm still giving my Reviewed-by based on the assumption that the g-tx-fifo-size values you have are working (at least for you)
Regards Martin
| |