lkml.org 
[lkml]   [2019]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/18] blktrace: change strncpy+truncation to strlcpy
    Jens, Steven,

    Jens Axboe wrote on Thu, Mar 14, 2019:
    > On 3/14/19 7:37 PM, Steven Rostedt wrote:
    > > I noticed this old patch in my inbox. It looks like a legit cleanup.
    > > Want to take it?
    >
    > Indeed, I've applied it. Thanks!

    Thanks. I am terribly sorry about this patch series to be honest, I did
    not prepare it properly and sent too many generic patches at once but
    more importantly some were unsafe (strlcpy expects the input string to
    be validly formatted, because it basically does strlen() on it to check
    how much hasn't been copied for its return value)
    I was pointed out strscpy instead as a safer alternative.

    In this case `name` comes from bdevname() which is disk_name() in
    block/partition-generic.c which is a snprintf, so we are guaranted
    null truncation from there and it should be OK, but I wanted to check
    and point it out.


    Anyway, thanks!
    --
    Dominique

    \
     
     \ /
      Last update: 2019-03-15 07:31    [W:4.193 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site