Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 16 Mar 2019 00:25:17 +0900 | Subject | Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG |
| |
On Thu, Mar 14, 2019 at 11:27 AM Michael Ellerman <mpe@ellerman.id.au> wrote: > > Mathieu Malaterre <malat@debian.org> writes: > > On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada > > <yamada.masahiro@socionext.com> wrote: > >> > >> On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre <malat@debian.org> wrote: > >> > > >> > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada > >> > <yamada.masahiro@socionext.com> wrote: > >> > > > >> > > I often test all Kconfig commands for all architectures. To ease my > >> > > workflow, I want 'make defconfig' at least working without any cross > >> > > compiler. > >> > > > >> > > Currently, arch/powerpc/Makefile checks CROSS_COMPILE to decide the > >> > > default defconfig source. > >> > > > >> > > If CROSS_COMPILE is unset, it is likely to be the native build, so > >> > > 'uname -m' is useful to choose the defconfig. If CROSS_COMPILE is set, > >> > > the user is cross-building (i.e. 'uname -m' is probably x86_64), so > >> > > it falls back to ppc64_defconfig. Yup, make sense. > >> > > > >> > > However, I want to run 'make ARCH=* defconfig' without setting > >> > > CROSS_COMPILE for each architecture. > >> > > > >> > > My suggestion is to check $(origin ARCH). > >> > > > >> > > When you cross-compile the kernel, you need to set ARCH from your > >> > > environment or from the command line. > >> > > > >> > > For the native build, you do not need to set ARCH. The default in > >> > > the top Makefile is used: > >> > > > >> > > ARCH ?= $(SUBARCH) > >> > > > >> > > Hence, $(origin ARCH) returns 'file'. > >> > > > >> > > Before this commit, 'make ARCH=powerpc defconfig' failed: > >> > > >> > In case you have not seen it, please check: > >> > > >> > http://patchwork.ozlabs.org/patch/1037835/ > >> > >> I did not know that because I do not subscribe to ppc ML. > >> > >> Michael's patch looks good to me. > > > > OK > > > >> > >> If you mimic x86, the following will work: > >> > > > > Nice! Michael do you have a preference ? > > Yeah I don't like playing games with ARCH. Doing so means auto builders > and other build scripts need to learn about the special rules for ARCH, > which is a pain. > > So I'll merge my patch, which I think will also work for Masahiro's > case. > > cheers
Yes, works for me.
Thanks!
-- Best Regards Masahiro Yamada
| |