Messages in this thread | | | Date | Fri, 15 Mar 2019 14:34:43 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v1 0/3] perf: Support a new coresum event qualifier |
| |
On Sat, Mar 16, 2019 at 12:04:13AM +0800, Jin Yao wrote: > The coresum event qualifier which sums up the event counts for both > hardware threads in a core. For example, > > perf stat -e cpu/event=0,umask=0x3,coresum=1/,cpu/event=0,umask=0x3/ > > In this example, we count the event 'ref-cycles' per-core and per-CPU in > one perf stat command-line. > > We can already support per-core counting with --per-core, but it's > often useful to do this together with other metrics that are collected > per CPU (per hardware thread). So this patch series supports this > per-core counting on a event level.
seems useful, but perhaps we should follow the --per-core option we already have and call it 'per-core' instead of coresum
jirka
> > Jin Yao (3): > perf: Add a coresum event qualifier > perf stat: Support coresum event qualifier > perf test: Add a simple test for term coresum > > tools/perf/Documentation/perf-stat.txt | 4 ++ > tools/perf/builtin-stat.c | 21 +++++++ > tools/perf/tests/parse-events.c | 10 ++- > tools/perf/util/evsel.c | 2 + > tools/perf/util/evsel.h | 3 + > tools/perf/util/parse-events.c | 27 +++++++++ > tools/perf/util/parse-events.h | 1 + > tools/perf/util/parse-events.l | 1 + > tools/perf/util/stat-display.c | 108 ++++++++++++++++++++++++--------- > tools/perf/util/stat.c | 8 ++- > 10 files changed, 151 insertions(+), 34 deletions(-) > > -- > 2.7.4 >
| |